[
https://issues.apache.org/jira/browse/SPARK-19567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862983#comment-15862983
]
Eren Avsarogullari commented on SPARK-19567:
--------------------------------------------
Hi [~srowen],
Thanks for quick response.
I prepared the following patch for this and it is related with
https://github.com/apache/spark/pull/15604
https://github.com/erenavsarogullari/spark/commit/d158b789c98923d5989f9fd50fd7fd3a4f1fc1ff
Also, i totally agree about public APIs and suggested patch is at the scheduler
implementation level(private[spark] Schedulable Entities and TaskSchedulerImpl)
so not the part of public APIs.
> Support some Schedulable variables immutability and access
> ----------------------------------------------------------
>
> Key: SPARK-19567
> URL: https://issues.apache.org/jira/browse/SPARK-19567
> Project: Spark
> Issue Type: Improvement
> Components: Scheduler
> Affects Versions: 2.1.0
> Reporter: Eren Avsarogullari
> Priority: Minor
>
> Support some Schedulable variables immutability and access
> Some Schedulable variables need refactoring for immutability and access
> modifiers as follows:
> - from vars to vals(if there is no requirement): This is important to support
> immutability as much as possible.
> Sample => Pool: weight, minShare, priority, name and
> taskSetSchedulingAlgorithm.
> - access modifiers: Specially, vars access needs to be restricted from other
> parts of codebase to prevent potential side effects. Sample:
> Sample => TaskSetManager: tasksSuccessful, totalResultSize, calculatedTasks
> etc...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
