Vasilis Vryniotis created SPARK-19787:
-----------------------------------------

             Summary: Different default regParam values in ALS
                 Key: SPARK-19787
                 URL: https://issues.apache.org/jira/browse/SPARK-19787
             Project: Spark
          Issue Type: Bug
          Components: MLlib
    Affects Versions: 2.1.0, 2.0.2, 2.0.1, 2.0.0
            Reporter: Vasilis Vryniotis


In the ALS method the default values of regParam do not match within the same 
file (lines 
[224](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L224)
 and 
[714](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L714)).
 In one place we set it to 1.0 and in the other to 0.1.

We can change the one of train() method to 0.1. The method is marked with 
DeveloperApi so it should not affect the users. Based on what I saw, whenever 
we use the particular method we provide all parameters, so the default does not 
matter. Only exception is the unit-tests on ALSSuite but the change does not 
break them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to