[
https://issues.apache.org/jira/browse/SPARK-19934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Owen updated SPARK-19934:
------------------------------
Priority: Trivial (was: Minor)
Explain why?
> code comments not very clearly in BlackListTracker.scala
> --------------------------------------------------------
>
> Key: SPARK-19934
> URL: https://issues.apache.org/jira/browse/SPARK-19934
> Project: Spark
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: zhoukang
> Priority: Trivial
>
> def handleRemovedExecutor(executorId: String): Unit = {
> // We intentionally do not clean up executors that are already
> blacklisted in
> // nodeToBlacklistedExecs, so that if another executor on the same node
> gets blacklisted, we can
> // blacklist the entire node. We also can't clean up
> executorIdToBlacklistStatus, so we can
> // eventually remove the executor after the timeout. Despite not
> clearing those structures
> // here, we don't expect they will grow too big since you won't get too
> many executors on one
> // node, and the timeout will clear it up periodically in any case.
> executorIdToFailureList -= executorId
> }
> i think the comments should be:
> // We intentionally do not clean up executors that are already blacklisted in
> // nodeToBlacklistedExecs, so that if
> {spark.blacklist.application.maxFailedExecutorsPerNode} - 1 executor on the
> same node gets blacklisted, we can
> // blacklist the entire node.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
