[
https://issues.apache.org/jira/browse/SPARK-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948526#comment-15948526
]
Apache Spark commented on SPARK-18901:
--------------------------------------
User 'wangmiao1981' has created a pull request for this issue:
https://github.com/apache/spark/pull/17478
> Require in LR LogisticAggregator is redundant
> ---------------------------------------------
>
> Key: SPARK-18901
> URL: https://issues.apache.org/jira/browse/SPARK-18901
> Project: Spark
> Issue Type: Improvement
> Components: ML
> Reporter: yuhao yang
> Priority: Minor
>
> require(numFeatures == features.size, ....)
> require(weight >= 0.0, ...)
> in LogisticAggregator (add and merge) will never be triggered as the
> dimension and weight has been checked in MultivariateOnlineSummarizer.
> Given the frequent usage of function add, the redundant require should be
> removed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
