[
https://issues.apache.org/jira/browse/SPARK-20180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953166#comment-15953166
]
Sean Owen commented on SPARK-20180:
-----------------------------------
Why not let the default be Int.MaxValue? if that's what this is about, update
the title to reflect it.
This is a behavior change by default, so we should think carefully about it.
What are the downsides -- why would someone have ever made it 10? presumably,
performance.
I don't see you've benchmarked the impact of making this unlimited by default.
You mention tests don't end and haven't established it's not due to your
change.
I don't think we can proceed with this in this state, right?
> Unlimited max pattern length in Prefix span
> -------------------------------------------
>
> Key: SPARK-20180
> URL: https://issues.apache.org/jira/browse/SPARK-20180
> Project: Spark
> Issue Type: Improvement
> Components: MLlib
> Affects Versions: 2.1.0
> Reporter: Cyril de Vogelaere
> Priority: Minor
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Right now, we need to use .setMaxPatternLength() method to
> specify is the maximum pattern length of a sequence. Any pattern longer than
> that won't be outputted.
> The current default maxPatternlength value being 10.
> This should be changed so that with input 0, all pattern of any length would
> be outputted. Additionally, the default value should be changed to 0, so that
> a new user could find all patterns in his dataset without looking at this
> parameter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
