[
https://issues.apache.org/jira/browse/SPARK-20203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953318#comment-15953318
]
Cyril de Vogelaere commented on SPARK-20203:
--------------------------------------------
I'm not splitting it, I deleted the other thread.
I did agree adding the zero special value might have a tiny negative effect on
performance, without adding new functionnalities.
So I closed it, following that line of thought.
This post, is just about changing the default value. Which, you agreed, can be
discussed.
That's a new context of discussion, so I created a new thread. This should make
more sense no ?
> Change default maxPatternLength value to Int.MaxValue in PrefixSpan
> -------------------------------------------------------------------
>
> Key: SPARK-20203
> URL: https://issues.apache.org/jira/browse/SPARK-20203
> Project: Spark
> Issue Type: Wish
> Components: MLlib
> Affects Versions: 2.1.0
> Reporter: Cyril de Vogelaere
> Priority: Trivial
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> I think changing the default value to Int.MaxValue would be more user
> friendly. At least for new users.
> Personally, when I run an algorithm, I expect it to find all solution by
> default. And a limited number of them, when I set the parameters to do so.
> The current implementation limit the length of solution patterns to 10.
> Thus preventing all solution to be printed when running slightly large
> datasets.
> I feel like that should be changed, but since this would change the default
> behavior of PrefixSpan. I think asking for the communities opinion should
> come first. So, what do you think ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
