Robert Stupp created SPARK-20344:
------------------------------------
Summary: Duplicate call in FairSchedulableBuilder.addTaskSetManager
Key: SPARK-20344
URL: https://issues.apache.org/jira/browse/SPARK-20344
Project: Spark
Issue Type: Improvement
Components: Scheduler
Affects Versions: 2.1.0
Reporter: Robert Stupp
Priority: Minor
{{org.apache.spark.scheduler.FairSchedulableBuilder#addTaskSetManager}}
contains the code snippet:
{code}
override def addTaskSetManager(manager: Schedulable, properties: Properties) {
var poolName = DEFAULT_POOL_NAME
var parentPool = rootPool.getSchedulableByName(poolName)
if (properties != null) {
poolName = properties.getProperty(FAIR_SCHEDULER_PROPERTIES,
DEFAULT_POOL_NAME)
parentPool = rootPool.getSchedulableByName(poolName)
if (parentPool == null) {
{code}
{{parentPool = rootPool.getSchedulableByName(poolName)}} is called twice if
{{properties != null}}.
I'm not sure whether this is an oversight or there's something else missing.
This piece of the code hasn't been modified since 2013, so I doubt that this is
a serious issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
