[
https://issues.apache.org/jira/browse/SPARK-20344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969901#comment-15969901
]
Robert Stupp commented on SPARK-20344:
--------------------------------------
Just saw it's a duplicate. Not a serious thing - just unnecessary.
I've setup a branch [on GitHub
here|https://github.com/apache/spark/compare/master...snazy:20344-dup-call-master?expand=1]
that rearranges the calls. Not sure whether you use pull-requests against the
ASF mirror.
> Duplicate call in FairSchedulableBuilder.addTaskSetManager
> ----------------------------------------------------------
>
> Key: SPARK-20344
> URL: https://issues.apache.org/jira/browse/SPARK-20344
> Project: Spark
> Issue Type: Improvement
> Components: Scheduler
> Affects Versions: 2.1.0
> Reporter: Robert Stupp
> Priority: Trivial
>
> {{org.apache.spark.scheduler.FairSchedulableBuilder#addTaskSetManager}}
> contains the code snippet:
> {code}
> override def addTaskSetManager(manager: Schedulable, properties:
> Properties) {
> var poolName = DEFAULT_POOL_NAME
> var parentPool = rootPool.getSchedulableByName(poolName)
> if (properties != null) {
> poolName = properties.getProperty(FAIR_SCHEDULER_PROPERTIES,
> DEFAULT_POOL_NAME)
> parentPool = rootPool.getSchedulableByName(poolName)
> if (parentPool == null) {
> {code}
> {{parentPool = rootPool.getSchedulableByName(poolName)}} is called twice if
> {{properties != null}}.
> I'm not sure whether this is an oversight or there's something else missing.
> This piece of the code hasn't been modified since 2013, so I doubt that this
> is a serious issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
