[
https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181227#comment-14181227
]
Sean Owen commented on SPARK-3359:
----------------------------------
[~holdenk_amp]'s PR https://github.com/apache/spark/pull/2893 indeed fixes the
immediate problem, thank you.
I find that the generated Java source code's generated javadoc still doesn't
parse as valid javadoc in Java 8. Some are directly fixable and I'll send
another PR with those touch-ups.
Some are just differences between scaladoc and javadoc that the plugin doesn't
quite handle:
@example / @note tags -- unrecognized, probably delete-able without much
effect, but seems like something the plugin could just ignore and pass on the
text as-is in generated Java code.
@group tag -- unrecognized, and may have more value to keep?
@param tag on class arguments -- end up as @param tags on the Java class which
are not valid (well they are for generic types). Should ideally end up as
constructor javadoc.
[[link]] syntax for URLs and methods is not the same and the direct translation
to javadoc doesn't work.
I will request some changes in the plugin to maybe pass on these. But bottom
line is this still won't work to make javadoc from Scala source code in Java 8.
Do we need that? maybe find a way to just javadoc the Java source.
> `sbt/sbt unidoc` doesn't work with Java 8
> -----------------------------------------
>
> Key: SPARK-3359
> URL: https://issues.apache.org/jira/browse/SPARK-3359
> Project: Spark
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 1.1.0
> Reporter: Xiangrui Meng
> Priority: Minor
>
> It seems that Java 8 is stricter on JavaDoc. I got many error messages like
> {code}
> [error]
> /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2:
> error: modifier private not allowed here
> [error] private abstract interface SparkHadoopMapRedUtil {
> [error] ^
> {code}
> This is minor because we can always use Java 6/7 to generate the doc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
