[
https://issues.apache.org/jira/browse/SPARK-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026021#comment-16026021
]
Sean Owen commented on SPARK-20891:
-----------------------------------
Can you refactor the code first, then make your change?
I understand your point but unless it's a huge change, you probably want to
make the change plus necessary other updates together.
Yes, someone might make a conflicting change in the meantime and you'd have to
be vigilant to keep your PR up to date until it's merged.
> Reduce duplicate code in typedaggregators.scala
> -----------------------------------------------
>
> Key: SPARK-20891
> URL: https://issues.apache.org/jira/browse/SPARK-20891
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 2.3.0
> Reporter: Ruben Janssen
>
> With SPARK-20411, a significant amount of functions will be added to
> typedaggregators.scala, resulting in a large amount of duplicate code
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
