[
https://issues.apache.org/jira/browse/SPARK-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087103#comment-16087103
]
Sean Owen commented on SPARK-21415:
-----------------------------------
I don't know, just because I don't know when or if anyone will decide to
address more. We don't need to address them all. So I don't think there's a
larger goal here.
> Triage scapegoat warnings, part 1
> ---------------------------------
>
> Key: SPARK-21415
> URL: https://issues.apache.org/jira/browse/SPARK-21415
> Project: Spark
> Issue Type: Improvement
> Components: GraphX, ML, Spark Core, SQL, Structured Streaming
> Affects Versions: 2.3.0
> Reporter: Sean Owen
> Assignee: Sean Owen
> Priority: Minor
>
> Following the results of the scapegoat plugin at
> https://docs.google.com/spreadsheets/d/1z7xNMjx7VCJLCiHOHhTth7Hh4R0F6LwcGjEwCDzrCiM/edit#gid=767668040
> and some initial triage, I'd like to address all of the valid instances of
> some classes of warning:
> - BigDecimal double constructor
> - Catching NPE
> - Finalizer without super
> - List.size is O(n)
> - Prefer Seq.empty
> - Prefer Set.empty
> - reverse.map instead of reverseMap
> - Type shadowing
> - Unnecessary if condition.
> - Use .log1p
> - Var could be val
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
