[ 
https://issues.apache.org/jira/browse/SPARK-21623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Owen resolved SPARK-21623.
-------------------------------
       Resolution: Fixed
    Fix Version/s: 2.3.0

Issue resolved by pull request 18832
[https://github.com/apache/spark/pull/18832]

> Comments of parentStats on ml/tree/impl/DTStatsAggregator.scala is wrong
> ------------------------------------------------------------------------
>
>                 Key: SPARK-21623
>                 URL: https://issues.apache.org/jira/browse/SPARK-21623
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 2.3.0
>            Reporter: Peng Meng
>            Priority: Trivial
>             Fix For: 2.3.0
>
>
> {code:java}
>    * Note: this is necessary because stats for the parent node are not 
> available
>    *       on the first iteration of tree learning.
>    */
>   private val parentStats: Array[Double] = new Array[Double](statsSize)
> {code}
> This comment is not right. Actually,  parentStats is not only used for the 
> first iteration. It is used with all the iteration for unordered featrues.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to