[ 
https://issues.apache.org/jira/browse/SPARK-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124531#comment-16124531
 ] 

Valeriy Avanesov commented on SPARK-14371:
------------------------------------------

Hi,

I've opened a PR regarding this Jira yesterday
https://github.com/apache/spark/pull/18924

However, something seems to be wrong -- the Jira is still not "in Progress" and 
the PR is not linked to it. Could anyone please check out what's wrong? 

> OnlineLDAOptimizer should not collect stats for each doc in mini-batch to 
> driver
> --------------------------------------------------------------------------------
>
>                 Key: SPARK-14371
>                 URL: https://issues.apache.org/jira/browse/SPARK-14371
>             Project: Spark
>          Issue Type: Improvement
>          Components: MLlib
>            Reporter: Joseph K. Bradley
>
> See this line: 
> https://github.com/apache/spark/blob/5743c6476dbef50852b7f9873112a2d299966ebd/mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala#L437
> The second element in each row of "stats" is a list with one Vector for each 
> document in the mini-batch.  Those are collected to the driver in this line:
> https://github.com/apache/spark/blob/5743c6476dbef50852b7f9873112a2d299966ebd/mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala#L456
> We should not collect those to the driver.  Rather, we should do the 
> necessary maps and aggregations in a distributed manner.  This will involve 
> modify the Dirichlet expectation implementation.  (This JIRA should be done 
> by someone knowledge about online LDA and Spark.)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to