[ 
https://issues.apache.org/jira/browse/SPARK-21757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Ash updated SPARK-21757:
-------------------------------
    Description: 
At the following two places if the {{e.reason}} value contains a single quote 
character, then the rendered JSON is invalid.

https://github.com/apache/spark/blob/v2.2.0/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala?utf8=%E2%9C%93#L158
https://github.com/apache/spark/blob/v2.2.0/core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala#L127

A quick fix could be to do replacement of {{'}} with html entity 
{noformat}&#39{noformat} and a longer term fix could be to not assemble JSON 
via string concatenation, and instead use a real JSON serialization library in 
those two places.

  was:
At the following two places if the {{e.reason}} value contains a single quote 
character, then the rendered JSON is invalid.

https://github.com/apache/spark/blob/v2.2.0/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala?utf8=%E2%9C%93#L158
https://github.com/apache/spark/blob/v2.2.0/core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala#L127

A quick fix could be to do replacement of {{'}} with html entity {{'}} and 
a longer term fix could be to not assemble JSON via string concatenation, and 
instead use a real JSON serialization library in those two places.


> Jobs page fails to load when executor removed event's reason contains single 
> quote
> ----------------------------------------------------------------------------------
>
>                 Key: SPARK-21757
>                 URL: https://issues.apache.org/jira/browse/SPARK-21757
>             Project: Spark
>          Issue Type: Bug
>          Components: Web UI
>    Affects Versions: 2.2.0
>            Reporter: Andrew Ash
>
> At the following two places if the {{e.reason}} value contains a single quote 
> character, then the rendered JSON is invalid.
> https://github.com/apache/spark/blob/v2.2.0/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala?utf8=%E2%9C%93#L158
> https://github.com/apache/spark/blob/v2.2.0/core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala#L127
> A quick fix could be to do replacement of {{'}} with html entity 
> {noformat}&#39{noformat} and a longer term fix could be to not assemble JSON 
> via string concatenation, and instead use a real JSON serialization library 
> in those two places.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to