[
https://issues.apache.org/jira/browse/SPARK-22269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcelo Vanzin reopened SPARK-22269:
------------------------------------
This is not a duplicate of that bug. If there's a bug about enabling lint-java
in the PR builder then this would be a dupe.
I agree with Andrew that these linter errors are annoying and if we really care
about them they should be enforced by the PR builder. So we should choose:
either we care about the java linter and run it everywhere, or we don't and we
disable it everywhere. The middle of the road we're in is super annoying.
> Java style checks should be run in Jenkins
> ------------------------------------------
>
> Key: SPARK-22269
> URL: https://issues.apache.org/jira/browse/SPARK-22269
> Project: Spark
> Issue Type: Improvement
> Components: Build
> Affects Versions: 2.3.0
> Reporter: Andrew Ash
> Priority: Minor
>
> A few times now I've gone to build the master branch and it's failed due to
> Java style errors, which I've sent in PRs to fix:
> - https://issues.apache.org/jira/browse/SPARK-22268
> - https://issues.apache.org/jira/browse/SPARK-21875
> Digging through the history a bit, it looks like this check used to run on
> Jenkins and was previously enabled at
> https://github.com/apache/spark/pull/10763 but then reverted at
> https://github.com/apache/spark/commit/4bcea1b8595424678aa6c92d66ba08c92e0fefe5
> We should work out what it takes to enable the Java check in Jenkins so these
> kinds of errors are caught in CI rather than afterwards post-merge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
