[
https://issues.apache.org/jira/browse/SPARK-22269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203902#comment-16203902
]
Sean Owen commented on SPARK-22269:
-----------------------------------
Sure, maybe it's possible to run through SBT. That would be ideal. (Or, one
day, drop this dual build thing.)
Emitting warnings seems better than nothing at all, but failing fast would be
more consistent with how scalastyle is handled.
It's not ideal to go fix the Java style violations every few months. Not a big
deal but not great.
> Java style checks should be run in Jenkins
> ------------------------------------------
>
> Key: SPARK-22269
> URL: https://issues.apache.org/jira/browse/SPARK-22269
> Project: Spark
> Issue Type: Improvement
> Components: Build
> Affects Versions: 2.3.0
> Reporter: Andrew Ash
> Priority: Minor
>
> A few times now I've gone to build the master branch and it's failed due to
> Java style errors, which I've sent in PRs to fix:
> - https://issues.apache.org/jira/browse/SPARK-22268
> - https://issues.apache.org/jira/browse/SPARK-21875
> Digging through the history a bit, it looks like this check used to run on
> Jenkins and was previously enabled at
> https://github.com/apache/spark/pull/10763 but then reverted at
> https://github.com/apache/spark/commit/4bcea1b8595424678aa6c92d66ba08c92e0fefe5
> We should work out what it takes to enable the Java check in Jenkins so these
> kinds of errors are caught in CI rather than afterwards post-merge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
