yuhao yang created SPARK-22502: ---------------------------------- Summary: OnlineLDAOptimizer variationalTopicInference might be able to handle empty documents Key: SPARK-22502 URL: https://issues.apache.org/jira/browse/SPARK-22502 Project: Spark Issue Type: Improvement Components: ML Affects Versions: 2.2.0 Reporter: yuhao yang Priority: Trivial
Currently we assume OnlineLDAOptimizer.variationalTopicInference cannot take empty documents and added a few checks during training and inference. Yet I tested and in my local env sending empty vectors to OnlineLDAOptimizer.variationalTopicInference does not trigger any error. If this is true, maybe we can remove the extra check. Please be cautious as compared with the gain (some code cleaning and little performance improvement), we do want to avoid a regression. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org