[ https://issues.apache.org/jira/browse/SPARK-22847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299474#comment-16299474 ]
wuyi commented on SPARK-22847: ------------------------------ [~srowen] So, how can I handle these little mistake properly next time I meet it, as I know this JIRA maybe not worth to bother you guys. Thanks! > Remove the duplicate code in AppStatusListener while assigning schedulingPool > for stage > ---------------------------------------------------------------------------------------- > > Key: SPARK-22847 > URL: https://issues.apache.org/jira/browse/SPARK-22847 > Project: Spark > Issue Type: Improvement > Components: Spark Core > Affects Versions: 2.2.1 > Reporter: wuyi > Assignee: wuyi > Priority: Trivial > Labels: newbie > Fix For: 2.3.0 > > > In AppStatusListener's onStageSubmitted(event: SparkListenerStageSubmitted) > method, there are duplicate code: > {code:java} > // schedulingPool was assigned twice with the same code > stage.schedulingPool = Option(event.properties).flatMap { p => > Option(p.getProperty("spark.scheduler.pool")) > }.getOrElse(SparkUI.DEFAULT_POOL_NAME) > {code} > But, it does not make any sense to do this and there are no comment to > explain for this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org