[ 
https://issues.apache.org/jira/browse/SPARK-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214261#comment-14214261
 ] 

Nathan M commented on SPARK-4147:
---------------------------------

This code just forces log4j on the end user which is less than ideal. SLF4J 
should avoid this, seems like something wrong is being done trying to set the 
log level like this... 

> Remove log4j dependency
> -----------------------
>
>                 Key: SPARK-4147
>                 URL: https://issues.apache.org/jira/browse/SPARK-4147
>             Project: Spark
>          Issue Type: Wish
>          Components: Spark Core
>    Affects Versions: 1.1.0
>            Reporter: Tobias Pfeiffer
>
> spark-core has a hard dependency on log4j, which shouldn't be necessary since 
> slf4j is used. I tried to exclude slf4j-log4j12 and log4j dependencies in my 
> sbt file.
> Excluding org.slf4j.slf4j-log4j12 works fine if logback is on the classpath. 
> However, removing the log4j dependency fails because in 
> https://github.com/apache/spark/blob/v1.1.0/core/src/main/scala/org/apache/spark/Logging.scala#L121
>  a static method of org.apache.log4j.LogManager is accessed *even if* log4j 
> is not in use.
> I guess removing all dependencies on log4j may be a bigger task, but it would 
> be a great help if the access to LogManager would be done only if log4j use 
> was detected before. (This is a 2-line change.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to