Sital Kedia commented on SPARK-23310:

[~yhuai] - Sorry about introducing the regression for TPC-DS queries. Let's set 
spark.unsafe.sorter.spill.read.ahead.enabled to false to unblock the release.  
Let me know if you want me to make a PR or you can do it yourself.


>> ReadAheadInputStream gets lock congestion

BTW, do you have idea where the lock contention is occuring? I will file a 
separate Jira and work on fixing it.

> Perf regression introduced by SPARK-21113
> -----------------------------------------
>                 Key: SPARK-23310
>                 URL: https://issues.apache.org/jira/browse/SPARK-23310
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 2.3.0
>            Reporter: Yin Huai
>            Priority: Blocker
> While running all TPC-DS queries with SF set to 1000, we noticed that Q95 
> (https://github.com/databricks/spark-sql-perf/blob/master/src/main/resources/tpcds_2_4/q95.sql)
>  has noticeable regression (11%). After looking into it, we found that the 
> regression was introduced by SPARK-21113. Specially, ReadAheadInputStream 
> gets lock congestion. After setting 
> spark.unsafe.sorter.spill.read.ahead.enabled set to false, the regression 
> disappear and the overall performance of all TPC-DS queries has improved.
> I am proposing that we set spark.unsafe.sorter.spill.read.ahead.enabled to 
> false by default for Spark 2.3 and re-enable it after addressing the lock 
> congestion issue. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to