[
https://issues.apache.org/jira/browse/SPARK-23447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenchen Fan reassigned SPARK-23447:
-----------------------------------
Assignee: Kris Mok
> Cleanup codegen template for Literal
> ------------------------------------
>
> Key: SPARK-23447
> URL: https://issues.apache.org/jira/browse/SPARK-23447
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Kris Mok
> Assignee: Kris Mok
> Priority: Major
> Fix For: 2.4.0
>
>
> Ideally, the codegen templates for {{Literal}} should emit literals in the
> {{isNull}} and {{value}} fields of {{ExprCode}} so that they can be
> effectively inlined into their use sites.
> But currently there are a couple of paths where {{Literal.doGenCode()}}
> return {{ExprCode}} that has non-trivial {{code}} field, and all of those are
> actually unnecessary.
> We can make a simple refactoring to make sure all codegen templates for
> {{Literal}} return empty {{code}} and simple literal/constant expressions in
> {{isNull}} and {{value}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
