[
https://issues.apache.org/jira/browse/SPARK-23769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409446#comment-16409446
]
Riaas Mokiem commented on SPARK-23769:
--------------------------------------
A few of us actually went through all of the "scalastyle disable" comments in
the production code of Spark Core (but not the test code). This is the only one
that seemed entirely unnecessary. But I found another one that should be easily
fixed, for which I'll create another issue and PR in a few hours.
I also have an issue and PR open for some documentation improvements
(SPARK-23579), if you could take a look at that.
> Remove unnecessary scalastyle check disabling
> ---------------------------------------------
>
> Key: SPARK-23769
> URL: https://issues.apache.org/jira/browse/SPARK-23769
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Affects Versions: 2.4.0
> Reporter: Riaas Mokiem
> Priority: Minor
>
> In `org/apache/spark/util/CompletionIterator.scala` the Scalastyle checker is
> disabled for 1 line of code. However, this line of code doesn't seem to
> violate any of the currently active rules for Scalastyle. So the Scalastyle
> checker doesn't need to be disabled there.
> I've tested this by removing the comments that disable the checker and
> running the checker with `build/mv scalastyle:check`. With the comments
> removed (so with the checker active for that line) the build still succeeds
> and no violations are shown in `core/target/scalastyle-output.xml`. I'll
> create a pull request to remove the comments that disable the checker.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
