[ 
https://issues.apache.org/jira/browse/SPARK-23892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kazuaki Ishizaki updated SPARK-23892:
-------------------------------------
    Description: 
The following code in {{UTF8StringSuite}} has no sense.
{code}
    assertTrue(s1.startsWith(s1));
    assertTrue(s1.endsWith(s1));
{code}

{code}
  test("lpad, rpad") {
    def padding(origin: String, pad: String, length: Int, isLPad: Boolean): 
String = {
      if (length <= 0) return ""
      if (length <= origin.length) {
        if (length <= 0) "" else origin.substring(0, length)
      } else {
       ...
{code}

The previous change broken lint-java check.

  was:
The following code in {{UTF8StringSuite}} has no sense.
{code}
    assertTrue(s1.startsWith(s1));
    assertTrue(s1.endsWith(s1));
{code}

The previous change broken lint-java check.


> Improve coverage and fix lint error in UTF8String-related Suite
> ---------------------------------------------------------------
>
>                 Key: SPARK-23892
>                 URL: https://issues.apache.org/jira/browse/SPARK-23892
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 2.3.0
>            Reporter: Kazuaki Ishizaki
>            Priority: Minor
>
> The following code in {{UTF8StringSuite}} has no sense.
> {code}
>     assertTrue(s1.startsWith(s1));
>     assertTrue(s1.endsWith(s1));
> {code}
> {code}
>   test("lpad, rpad") {
>     def padding(origin: String, pad: String, length: Int, isLPad: Boolean): 
> String = {
>       if (length <= 0) return ""
>       if (length <= origin.length) {
>         if (length <= 0) "" else origin.substring(0, length)
>       } else {
>        ...
> {code}
> The previous change broken lint-java check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to