[ https://issues.apache.org/jira/browse/SPARK-23989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442568#comment-16442568 ]
Wenchen Fan edited comment on SPARK-23989 at 4/18/18 2:47 PM: -------------------------------------------------------------- OK now I see the problem, `ShuffleExchangeExec.needToCopyObjectsBeforeShuffle` doesn't catch all the cases, so we may produce wrong result. was (Author: cloud_fan): OK now I see the problem, `ShuffleExchangeExec.needToCopyObjectsBeforeShuffle` doesn't catch all the cases, so we may reproduce wrong result. > When using `SortShuffleWriter`, the data will be overwritten > ------------------------------------------------------------ > > Key: SPARK-23989 > URL: https://issues.apache.org/jira/browse/SPARK-23989 > Project: Spark > Issue Type: Bug > Components: Spark Core > Affects Versions: 2.3.0 > Reporter: liuxian > Priority: Critical > > {color:#333333}When using `SortShuffleWriter`, we only insert > '{color}{color:#cc7832}AnyRef{color}{color:#333333}' into > '{color}PartitionedAppendOnlyMap{color:#333333}' or > '{color}PartitionedPairBuffer{color:#333333}'.{color} > {color:#333333}For this function:{color} > {color:#cc7832}override def {color}{color:#ffc66d}write{color}(records: > {color:#4e807d}Iterator{color}[Product2[{color:#4e807d}K{color}{color:#cc7832}, > {color}{color:#4e807d}V{color}]]) > the value of 'records' is `UnsafeRow`, so the value will be overwritten > {color:#333333} {color} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org