Izek Greenfield created SPARK-25093:

             Summary: CodeFormatter could avoid creating regex object again and 
                 Key: SPARK-25093
                 URL: https://issues.apache.org/jira/browse/SPARK-25093
             Project: Spark
          Issue Type: Improvement
          Components: Spark Core
    Affects Versions: 2.4.0
            Reporter: Izek Greenfield

in class `CodeFormatter` 

method: `stripExtraNewLinesAndComments`

could be refactored to: 

// Some comments here
 val commentReg =
    ("""([ |\t]*?\/\*[\s|\S]*?\*\/[ |\t]*?)|""" +    // strip /*comment*/
      """([ |\t]*?\/\/[\s\S]*?\n)""").r              // strip //comment
  val emptyRowsReg = """\n\s*\n""".r
def stripExtraNewLinesAndComments(input: String): String = {
    val codeWithoutComment = commentReg.replaceAllIn(input, "")
    emptyRowsReg.replaceAllIn(codeWithoutComment, "\n") // strip ExtraNewLines

so the Regex would be compiled only once.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to