[ 
https://issues.apache.org/jira/browse/SPARK-25321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612436#comment-16612436
 ] 

Joseph K. Bradley commented on SPARK-25321:
-------------------------------------------

You're right; these are breaking changes.  If we're sticking with the rules, 
then we should revert these in branch-2.4, but we could keep them in master if 
the next release is 3.0.  Is it easy to revert these PRs, or have they 
collected conflicts by now?

> ML, Graph 2.4 QA: API: New Scala APIs, docs
> -------------------------------------------
>
>                 Key: SPARK-25321
>                 URL: https://issues.apache.org/jira/browse/SPARK-25321
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Documentation, GraphX, ML, MLlib
>    Affects Versions: 2.4.0
>            Reporter: Weichen Xu
>            Assignee: Yanbo Liang
>            Priority: Blocker
>
> Audit new public Scala APIs added to MLlib & GraphX. Take note of:
>  * Protected/public classes or methods. If access can be more private, then 
> it should be.
>  * Also look for non-sealed traits.
>  * Documentation: Missing? Bad links or formatting?
> *Make sure to check the object doc!*
> As you find issues, please create JIRAs and link them to this issue. 
> For *user guide issues* link the new JIRAs to the relevant user guide QA issue



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to