[ 
https://issues.apache.org/jira/browse/SPARK-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612947#comment-16612947
 ] 

Wenchen Fan commented on SPARK-25378:
-------------------------------------

[~viirya] Can you take a look and see how hard it is to fix it?

After a quick look, I think this works in 2.3 if and only if: the 
`GenericArrayData` is created with `Array[String]` (i.e. a malformed 
ArrayData), and we wrongly call the `toArray[String](StringType)` method.

A quick solution is to revert SPARK-23875 from 2.4, but then we sacrifice 
performance to retain a buggy but backward-compatible behavior. So we need to 
make a trade off here.

> ArrayData.toArray(StringType) assume UTF8String in 2.4
> ------------------------------------------------------
>
>                 Key: SPARK-25378
>                 URL: https://issues.apache.org/jira/browse/SPARK-25378
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Xiangrui Meng
>            Priority: Critical
>
> The following code works in 2.3.1 but failed in 2.4.0-SNAPSHOT:
> {code}
> import org.apache.spark.sql.catalyst.util._
> import org.apache.spark.sql.types.StringType
> ArrayData.toArrayData(Array("a", "b")).toArray[String](StringType)
> res0: Array[String] = Array(a, b)
> {code}
> In 2.4.0-SNAPSHOT, the error is
> {code}java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.spark.unsafe.types.UTF8String
>   at 
> org.apache.spark.sql.catalyst.util.GenericArrayData.getUTF8String(GenericArrayData.scala:75)
>   at 
> org.apache.spark.sql.catalyst.InternalRow$$anonfun$getAccessor$8.apply(InternalRow.scala:136)
>   at 
> org.apache.spark.sql.catalyst.InternalRow$$anonfun$getAccessor$8.apply(InternalRow.scala:136)
>   at org.apache.spark.sql.catalyst.util.ArrayData.toArray(ArrayData.scala:178)
>   ... 51 elided
> {code}
> cc: [~cloud_fan] [~yogeshg]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to