Hyukjin Kwon created SPARK-25779:
------------------------------------
Summary: Remove SQL query tests for function documentation by
DESCRIBE FUNCTION at SQLQueryTestSuite
Key: SPARK-25779
URL: https://issues.apache.org/jira/browse/SPARK-25779
Project: Spark
Issue Type: Test
Components: SQL, Tests
Affects Versions: 3.0.0
Reporter: Hyukjin Kwon
Currently, there are some tests testing function descriptions:
{code}
$ grep -ir "describe function" sql/core/src/test/resources/sql-tests/inputs
sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe
function to_json;
sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe
function extended to_json;
sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe
function from_json;
sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe
function extended from_json;
{code}
Looks there are not quite good points about testing them since we're not going
to test documentation itself.
For {{DESCRIBE FCUNTION}} functionaility itself, they are already being tested
here and there.
See the test failures in https://github.com/apache/spark/pull/18749 (where I
added examples to function descriptions)
We better remove those tests so that people don't add such tests in the SQL
tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
