[ 
https://issues.apache.org/jira/browse/SPARK-25892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671713#comment-16671713
 ] 

Apache Spark commented on SPARK-25892:
--------------------------------------

User 'kevinyu98' has created a pull request for this issue:
https://github.com/apache/spark/pull/22918

> AttributeReference.withMetadata method should have return type 
> AttributeReference
> ---------------------------------------------------------------------------------
>
>                 Key: SPARK-25892
>                 URL: https://issues.apache.org/jira/browse/SPARK-25892
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Jari Kujansuu
>            Priority: Trivial
>
> AttributeReference.withMetadata method should have return type 
> AttributeReference instead of Attribute.
> AttributeReference overrides withMetadata method defined in Attribute super 
> class and returns AttributeReference instance but method's return type is 
> Attribute unlike in other with... methods overridden by AttributeReference.
> In some cases you have to cast the return value back to AttributeReference.
> For example if you want to modify metadata for AttributeReference in 
> LogicalRelation you have to cast return value of withMetadata back to 
> AttributeReference because LogicalRelation takes Seq[AttributeReference] as 
> argument.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to