[ 
https://issues.apache.org/jira/browse/SPARK-26297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715127#comment-16715127
 ] 

ASF GitHub Bot commented on SPARK-26297:
----------------------------------------

hvanhovell commented on a change in pull request #23249: [SPARK-26297][SQL] 
improve the doc of Distribution/Partitioning
URL: https://github.com/apache/spark/pull/23249#discussion_r240300150
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
 ##########
 @@ -241,12 +240,12 @@ case class HashPartitioning(expressions: 
Seq[Expression], numPartitions: Int)
 
 /**
  * Represents a partitioning where rows are split across partitions based on 
some total ordering of
- * the expressions specified in `ordering`.  When data is partitioned in this 
manner the following
- * two conditions are guaranteed to hold:
- *  - All row where the expressions in `ordering` evaluate to the same values 
will be in the same
- *    partition.
- *  - Each partition will have a `min` and `max` row, relative to the given 
ordering.  All rows
- *    that are in between `min` and `max` in this `ordering` will reside in 
this partition.
+ * the expressions specified in `ordering`.  When data is partitioned in this 
manner, it guarantees:
+ *   - Given any 2 adjacent partitions, all the rows of the second partition 
must be larger than
 
 Review comment:
   Nit don't use bullets if you have only one of them

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> improve the doc of Distribution/Partitioning
> --------------------------------------------
>
>                 Key: SPARK-26297
>                 URL: https://issues.apache.org/jira/browse/SPARK-26297
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Wenchen Fan
>            Assignee: Wenchen Fan
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to