[
https://issues.apache.org/jira/browse/SPARK-25877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716023#comment-16716023
]
ASF GitHub Bot commented on SPARK-25877:
----------------------------------------
mccheah commented on a change in pull request #23220: [SPARK-25877][k8s] Move
all feature logic to feature classes.
URL: https://github.com/apache/spark/pull/23220#discussion_r240454863
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/PodBuilderSuite.scala
##########
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s
+
+import java.io.File
+
+import io.fabric8.kubernetes.api.model.{Config => _, _}
+import io.fabric8.kubernetes.client.KubernetesClient
+import io.fabric8.kubernetes.client.dsl.{MixedOperation, PodResource}
+import org.mockito.Matchers.any
+import org.mockito.Mockito.{mock, never, verify, when}
+import scala.collection.JavaConverters._
+
+import org.apache.spark.{SparkConf, SparkException, SparkFunSuite}
+import org.apache.spark.deploy.k8s._
+import org.apache.spark.internal.config.ConfigEntry
+
+abstract class PodBuilderSuite extends SparkFunSuite {
+
+ protected def templateFileConf: ConfigEntry[_]
+
+ protected def buildPod(sparkConf: SparkConf, client: KubernetesClient):
SparkPod
+
+ private val baseConf = new SparkConf(false)
+ .set(Config.CONTAINER_IMAGE, "spark-executor:latest")
+
+ test("use empty initial pod if template is not specified") {
+ val client = mock(classOf[KubernetesClient])
+ buildPod(baseConf.clone(), client)
+ verify(client, never()).pods()
+ }
+
+ test("load pod template if specified") {
+ val client = mockKubernetesClient()
+ val sparkConf = baseConf.clone().set(templateFileConf.key,
"template-file.yaml")
+ val pod = buildPod(sparkConf, client)
+ verifyPod(pod)
+ }
+
+ test("complain about misconfigured pod template") {
+ val client = mockKubernetesClient(
+ new PodBuilder()
+ .withNewMetadata()
+ .addToLabels("test-label-key", "test-label-value")
+ .endMetadata()
+ .build())
+ val sparkConf = baseConf.clone().set(templateFileConf.key,
"template-file.yaml")
+ val exception = intercept[SparkException] {
+ buildPod(sparkConf, client)
+ }
+ assert(exception.getMessage.contains("Could not load pod from template
file."))
+ }
+
+ private def mockKubernetesClient(pod: Pod = podWithSupportedFeatures()):
KubernetesClient = {
+ val kubernetesClient = mock(classOf[KubernetesClient])
+ val pods =
+ mock(classOf[MixedOperation[Pod, PodList, DoneablePod, PodResource[Pod,
DoneablePod]]])
+ val podResource = mock(classOf[PodResource[Pod, DoneablePod]])
+ when(kubernetesClient.pods()).thenReturn(pods)
+ when(pods.load(any(classOf[File]))).thenReturn(podResource)
+ when(podResource.get()).thenReturn(pod)
+ kubernetesClient
+ }
+
+ private def verifyPod(pod: SparkPod): Unit = {
Review comment:
The number of things this test checks is remarkable, and it is very much
possible to accidentally omit checking the application of a specific feature
when a new one is added for either the driver or executor. This is why we had
the overridable feature steps in the original incarnation of these tests. Not
mocking the substeps leads us to need to check that some specific aspect of
each step has been applied. Can we go back to mocking the different steps so
that this test can be more easily modified when we add more features? Or else
can we abstract away the idea that these steps are applied without this test
itself needing to know what the step itself actually does?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Put all feature-related code in the feature step itself
> -------------------------------------------------------
>
> Key: SPARK-25877
> URL: https://issues.apache.org/jira/browse/SPARK-25877
> Project: Spark
> Issue Type: Improvement
> Components: Kubernetes
> Affects Versions: 2.4.0
> Reporter: Marcelo Vanzin
> Priority: Major
>
> This is a child task of SPARK-25874. It covers having all the code related to
> features in the feature steps themselves, including logic about whether a
> step should be applied or not.
> Please refer to the parent bug for further details.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
