[
https://issues.apache.org/jira/browse/SPARK-26337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716733#comment-16716733
]
ASF GitHub Bot commented on SPARK-26337:
----------------------------------------
viirya commented on issue #23284: [SPARK-26337][SQL][TEST] Add benchmark for
LongToUnsafeRowMap
URL: https://github.com/apache/spark/pull/23284#issuecomment-446143380
```
Using Long variables (master):
[info] Java HotSpot(TM) 64-Bit Server VM 1.8.0_181-b13 on Mac OS X 10.13.6
[info] Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
[info] LongToUnsafeRowMap metrics: Best/Avg Time(ms)
Rate(M/s) Per Row(ns) Relative
[info]
------------------------------------------------------------------------------------------------
[info] LongToUnsafeRowMap 1220 / 1233
0.4 2439.1 1.0X
LongAdder (PR 23214):
[info] Java HotSpot(TM) 64-Bit Server VM 1.8.0_181-b13 on Mac OS X 10.13.6
[info] Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
[info] LongToUnsafeRowMap metrics: Best/Avg Time(ms)
Rate(M/s) Per Row(ns) Relative
[info]
------------------------------------------------------------------------------------------------
[info] LongToUnsafeRowMap 401 / 460
1.2 802.2 1.0X
No metrics:
[info] Java HotSpot(TM) 64-Bit Server VM 1.8.0_181-b13 on Mac OS X 10.13.6
[info] Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
[info] LongToUnsafeRowMap metrics: Best/Avg Time(ms)
Rate(M/s) Per Row(ns) Relative
[info]
------------------------------------------------------------------------------------------------
[info] LongToUnsafeRowMap 243 / 347
2.1 485.0 1.0X
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add benchmark for LongToUnsafeRowMap
> ------------------------------------
>
> Key: SPARK-26337
> URL: https://issues.apache.org/jira/browse/SPARK-26337
> Project: Spark
> Issue Type: Test
> Components: SQL
> Affects Versions: 3.0.0
> Reporter: Liang-Chi Hsieh
> Priority: Major
>
> Regarding the performance issue of SPARK-26155, I think it is better to add a
> benchmark for LongToUnsafeRowMap which is the root cause of performance
> regression. It can be easier to show performance difference between different
> metric implementation in LongToUnsafeRowMap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
