[
https://issues.apache.org/jira/browse/SPARK-26193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717039#comment-16717039
]
ASF GitHub Bot commented on SPARK-26193:
----------------------------------------
xuanyuanking commented on a change in pull request #23207: [SPARK-26193][SQL]
Implement shuffle write metrics in SQL
URL: https://github.com/apache/spark/pull/23207#discussion_r239995006
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala
##########
@@ -38,13 +38,21 @@ case class CollectLimitExec(limit: Int, child: SparkPlan)
extends UnaryExecNode
override def outputPartitioning: Partitioning = SinglePartition
override def executeCollect(): Array[InternalRow] = child.executeTake(limit)
private val serializer: Serializer = new
UnsafeRowSerializer(child.output.size)
- override lazy val metrics =
SQLShuffleMetricsReporter.createShuffleReadMetrics(sparkContext)
+ private lazy val writeMetrics =
+ SQLShuffleWriteMetricsReporter.createShuffleWriteMetrics(sparkContext)
+ private lazy val readMetrics =
+ SQLShuffleMetricsReporter.createShuffleReadMetrics(sparkContext)
Review comment:
Yea that was done and revert in
https://github.com/apache/spark/pull/23207/commits/7d104ebe854effb3d8ceb63cd408b9749cee1a8a,
will separate to another pr after this. Done in #23286.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement shuffle write metrics in SQL
> --------------------------------------
>
> Key: SPARK-26193
> URL: https://issues.apache.org/jira/browse/SPARK-26193
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 3.0.0
> Reporter: Xiao Li
> Assignee: Yuanjian Li
> Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
