[ 
https://issues.apache.org/jira/browse/SPARK-26337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717412#comment-16717412
 ] 

ASF GitHub Bot commented on SPARK-26337:
----------------------------------------

cloud-fan commented on issue #23284: [SPARK-26337][SQL][TEST] Add benchmark for 
LongToUnsafeRowMap
URL: https://github.com/apache/spark/pull/23284#issuecomment-446249386
 
 
   can you update 
https://github.com/apache/spark/pull/23284#issuecomment-446143380 ?
   
   The revert PR is already merged, so we should revert the revert PR and run 
the benchmark again, and post the results in the comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add benchmark for LongToUnsafeRowMap
> ------------------------------------
>
>                 Key: SPARK-26337
>                 URL: https://issues.apache.org/jira/browse/SPARK-26337
>             Project: Spark
>          Issue Type: Test
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Liang-Chi Hsieh
>            Priority: Major
>
> Regarding the performance issue of SPARK-26155, I think it is better to add a 
> benchmark for LongToUnsafeRowMap which is the root cause of performance 
> regression. It can be easier to show performance difference between different 
> metric implementation in LongToUnsafeRowMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to