[
https://issues.apache.org/jira/browse/SPARK-26337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717933#comment-16717933
]
ASF GitHub Bot commented on SPARK-26337:
----------------------------------------
srowen commented on issue #23284: [SPARK-26337][SQL][TEST] Add benchmark for
LongToUnsafeRowMap
URL: https://github.com/apache/spark/pull/23284#issuecomment-446347640
There's no good reason why 64-bit reads/writes shouldn't be atomic on a
64-bit machine, and I assume everything we're testing on is 64-bit these days.
It was an issue in the past, and yes as you note, the JLS seems to allow for it
to be implementation-specific. No idea...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add benchmark for LongToUnsafeRowMap
> ------------------------------------
>
> Key: SPARK-26337
> URL: https://issues.apache.org/jira/browse/SPARK-26337
> Project: Spark
> Issue Type: Test
> Components: SQL
> Affects Versions: 3.0.0
> Reporter: Liang-Chi Hsieh
> Priority: Major
>
> Regarding the performance issue of SPARK-26155, I think it is better to add a
> benchmark for LongToUnsafeRowMap which is the root cause of performance
> regression. It can be easier to show performance difference between different
> metric implementation in LongToUnsafeRowMap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
