[
https://issues.apache.org/jira/browse/SPARK-25212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717962#comment-16717962
]
ASF GitHub Bot commented on SPARK-25212:
----------------------------------------
srowen commented on a change in pull request #23273:
[SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule
URL: https://github.com/apache/spark/pull/23273#discussion_r240781452
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1370,10 +1370,10 @@ object DecimalAggregates extends Rule[LogicalPlan] {
}
/**
- * Converts local operations (i.e. ones that don't require data exchange) on
LocalRelation to
- * another LocalRelation.
+ * Converts local operations (i.e. ones that don't require data exchange) on
[[LocalRelation]] to
+ * another [[LocalRelation]].
*
- * This is relatively simple as it currently handles only 2 single case:
Project and Limit.
+ * This rule currently handles 3 cases: [[Project]], [[Limit]] and [[Filter]].
Review comment:
Maybe we should just not specify this in the docs. Are you sure the
`[[...]]` links work when you generate scaladoc? the test builder doesn't
check. I've seen many errors/warnings generated by some types of links.
If so again maybe easier to restrict this to merely removing this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support Filter in ConvertToLocalRelation
> ----------------------------------------
>
> Key: SPARK-25212
> URL: https://issues.apache.org/jira/browse/SPARK-25212
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 2.3.1
> Reporter: Bogdan Raducanu
> Assignee: Bogdan Raducanu
> Priority: Major
> Fix For: 2.4.0
>
>
> ConvertToLocalRelation can make short queries faster but currently it only
> supports Project and Limit.
> It can be extended with other operators such as Filter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
