[
https://issues.apache.org/jira/browse/SPARK-26311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718112#comment-16718112
]
ASF GitHub Bot commented on SPARK-26311:
----------------------------------------
HeartSaVioR commented on a change in pull request #23260: [SPARK-26311][YARN]
New feature: custom log URL for stdout/stderr
URL: https://github.com/apache/spark/pull/23260#discussion_r240817633
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala
##########
@@ -246,13 +253,57 @@ private[yarn] class ExecutorRunnable(
sys.env.get("SPARK_USER").foreach { user =>
val containerId = ConverterUtils.toString(c.getId)
val address = c.getNodeHttpAddress
- val baseUrl =
s"$httpScheme$address/node/containerlogs/$containerId/$user"
- env("SPARK_LOG_URL_STDERR") = s"$baseUrl/stderr?start=-4096"
- env("SPARK_LOG_URL_STDOUT") = s"$baseUrl/stdout?start=-4096"
+ val customLogUrl = sparkConf.get(config.CUSTOM_LOG_URL)
+
+ val envNameToFileNameMap = Map("SPARK_LOG_URL_STDERR" -> "stderr",
+ "SPARK_LOG_URL_STDOUT" -> "stdout")
+ val logUrls = ExecutorRunnable.buildLogUrls(customLogUrl, httpScheme,
address,
+ clusterId, containerId, user, envNameToFileNameMap)
+ logUrls.foreach { case (envName, url) =>
+ env(envName) = url
+ }
}
}
env
}
}
+
+private[yarn] object ExecutorRunnable {
+ def buildLogUrls(
+ logUrlPattern: String,
+ httpScheme: String,
+ nodeHttpAddress: String,
+ clusterId: Option[String],
+ containerId: String,
+ user: String,
+ envNameToFileNameMap: Map[String, String]): Map[String, String] = {
Review comment:
Ah yes I just confused indent rule between method parameters and return...
Nice catch. Will address.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [YARN] New feature: custom log URL for stdout/stderr
> ----------------------------------------------------
>
> Key: SPARK-26311
> URL: https://issues.apache.org/jira/browse/SPARK-26311
> Project: Spark
> Issue Type: Improvement
> Components: YARN
> Affects Versions: 2.4.0
> Reporter: Jungtaek Lim
> Priority: Major
>
> Spark has been setting static log URLs for YARN application, which points to
> NodeManager webapp. Normally it would work for both running apps and finished
> apps, but there're also other approaches on maintaining application logs,
> like having external log service which enables to avoid application log url
> to be a deadlink when NodeManager is not accessible. (Node decommissioned,
> elastic nodes, etc.)
> Spark can provide a new configuration for custom log url on YARN mode, which
> end users can set it properly to point application log to external log
> service.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
