[
https://issues.apache.org/jira/browse/SPARK-26368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720809#comment-16720809
]
ASF GitHub Bot commented on SPARK-26368:
----------------------------------------
rxin opened a new pull request #23317: [SPARK-26368][SQL] Make it clear that
getOrInferFileFormatSchema doesn't create InMemoryFileIndex
URL: https://github.com/apache/spark/pull/23317
## What changes were proposed in this pull request?
I was looking at the code and it was a bit difficult to see the life cycle
of InMemoryFileIndex passed into getOrInferFileFormatSchema, because once it is
passed in, and another time it was created in getOrInferFileFormatSchema. It'd
be easier to understand the life cycle if we move the creation of it out.
## How was this patch tested?
This is a simple code move and should be covered by existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make it clear that getOrInferFileFormatSchema doesn't create InMemoryFileIndex
> ------------------------------------------------------------------------------
>
> Key: SPARK-26368
> URL: https://issues.apache.org/jira/browse/SPARK-26368
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 2.4.0
> Reporter: Reynold Xin
> Assignee: Reynold Xin
> Priority: Major
>
> I was looking at the code and it was a bit difficult to see the life cycle of
> InMemoryFileIndex passed into getOrInferFileFormatSchema, because once it is
> passed in, and another time it was created in getOrInferFileFormatSchema.
> It'd be easier to understand the life cycle if we move the creation of it out.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
