[
https://issues.apache.org/jira/browse/SPARK-26360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hyukjin Kwon reassigned SPARK-26360:
------------------------------------
Assignee: Wu Wenjie
> Avoid extra validateQuery call in createStreamingWriteSupport
> -------------------------------------------------------------
>
> Key: SPARK-26360
> URL: https://issues.apache.org/jira/browse/SPARK-26360
> Project: Spark
> Issue Type: Improvement
> Components: Structured Streaming
> Affects Versions: 2.3.2, 2.4.0
> Reporter: Wu Wenjie
> Assignee: Wu Wenjie
> Priority: Trivial
> Fix For: 3.0.0
>
>
> When I'm reading structured streaming source code, I find there is a
> redundant KafkaWriter.validateQuery() function call in
> createStreamingWriteSupport func in class `KafkaSourceProvider`.
> {code:scala}
> // KafkaSourceProvider.scala
> override def createStreamingWriteSupport(
> queryId: String,
> schema: StructType,
> mode: OutputMode,
> options: DataSourceOptions): StreamingWriteSupport = {
> .....
> // validate once here
> KafkaWriter.validateQuery(schema.toAttributes, producerParams, topic)
> // validate twice here
> new KafkaStreamingWriteSupport(topic, producerParams, schema)
> }
> // KafkaStreamingWriteSupport.scala
> class KafkaStreamingWriteSupport(
> topic: Option[String],
> producerParams: ju.Map[String, Object],
> schema: StructType)
> extends StreamingWriteSupport {
> validateQuery(schema.toAttributes, producerParams, topic)
> ....
> }
> {code}
>
> I think we just need to remove one of these two.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
