[
https://issues.apache.org/jira/browse/SPARK-26327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722625#comment-16722625
]
ASF GitHub Bot commented on SPARK-26327:
----------------------------------------
gatorsmile opened a new pull request #23328: [SPARK-26327][SQL][FOLLOW-UP]
Refactor the code and restore the metrics name
URL: https://github.com/apache/spark/pull/23328
## What changes were proposed in this pull request?
- The original comment about `updateDriverMetrics` is not right.
- Refactor the code to ensure `selectedPartitions ` has been set before
sending the driver-side metrics.
- Restore the original name, which is more general and extendable.
## How was this patch tested?
The existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Metrics in FileSourceScanExec not update correctly while
> relation.partitionSchema is set
> ----------------------------------------------------------------------------------------
>
> Key: SPARK-26327
> URL: https://issues.apache.org/jira/browse/SPARK-26327
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 2.4.0
> Reporter: Yuanjian Li
> Assignee: Yuanjian Li
> Priority: Major
> Fix For: 2.2.3, 2.3.3, 2.4.1, 3.0.0
>
>
> As currently approach in `FileSourceScanExec`, the metrics of "numFiles" and
> "metadataTime"(fileListingTime) were updated while lazy val
> `selectedPartitions` initialized in the scenario of relation.partitionSchema
> is set. But `selectedPartitions` will be initialized by `metadata` at first,
> which is called by `queryExecution.toString` in
> `SQLExecution.withNewExecutionId`. So while the
> `SQLMetrics.postDriverMetricUpdates` called, there's no corresponding
> liveExecutions in SQLAppStatusListener, the metrics update is not work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
