[
https://issues.apache.org/jira/browse/SPARK-26704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750366#comment-16750366
]
Rob Vesse commented on SPARK-26704:
-----------------------------------
Yes sorry I'm conflating with the build context with the image contents. So
you're correct there isn't anything to do here. Will close as Not a Problem
> docker-image-tool.sh should copy custom Dockerfiles into the build context
> for inclusion in images
> --------------------------------------------------------------------------------------------------
>
> Key: SPARK-26704
> URL: https://issues.apache.org/jira/browse/SPARK-26704
> Project: Spark
> Issue Type: Improvement
> Components: Kubernetes
> Affects Versions: 2.4.0
> Reporter: Rob Vesse
> Priority: Major
>
> As surfaced in the discussion on the PR for SPARK-26687
> (https://github.com/apache/spark/pull/23613) when using custom Dockerfiles
> these are not copied into the build context. Rather the build context
> includes the default Dockerfiles from Spark regardless of what Dockerfiles
> the end user actually used to build the images.
> The suggestion in the PR was that the script should copy in the custom
> Dockerfiles over the stock Dockerfiles. This potentially aids in
> reproducing the images later because someone with an image can get the exact
> Dockerfile used to build that image.
> A related issue is that the script allows for and even in some cases
> implicitly uses Docker build arguments as part of building the images. In
> the case where build arguments are used these should probably also be
> captured in the image to aid reproducibility.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
