[
https://issues.apache.org/jira/browse/SPARK-27220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802202#comment-16802202
]
Imran Rashid commented on SPARK-27220:
--------------------------------------
sorry for the delay. i don't have a really strong opinion here. It does seem
that field is only used by yarn. But because its getting updated inside the
handling of {{RegisterExecutor}}, its kind of a headache to extract.
I actually think executorIds are really always ints -- that field is only a
string because there are places the string "driver" is used as an "executorId".
Eg. in standalone mode
https://github.com/apache/spark/blob/05168e725d2a17c4164ee5f9aa068801ec2454f4/core/src/main/scala/org/apache/spark/deploy/master/ApplicationInfo.scala#L70
I feel like this is too minor to bother with, really ...
> Remove Yarn specific leftover from CoarseGrainedSchedulerBackend
> ----------------------------------------------------------------
>
> Key: SPARK-27220
> URL: https://issues.apache.org/jira/browse/SPARK-27220
> Project: Spark
> Issue Type: Task
> Components: Spark Core, YARN
> Affects Versions: 2.0.2, 2.1.3, 2.2.3, 2.3.3, 2.4.0
> Reporter: Jacek Lewandowski
> Priority: Minor
>
> {{CoarseGrainedSchedulerBackend}} has the following field:
> {code:scala}
> // The num of current max ExecutorId used to re-register appMaster
> @volatile protected var currentExecutorIdCounter = 0
> {code}
> which is then updated:
> {code:scala}
> case RegisterExecutor(executorId, executorRef, hostname, cores,
> logUrls) =>
> ...
> // This must be synchronized because variables mutated
> // in this block are read when requesting executors
> CoarseGrainedSchedulerBackend.this.synchronized {
> executorDataMap.put(executorId, data)
> if (currentExecutorIdCounter < executorId.toInt) {
> currentExecutorIdCounter = executorId.toInt
> }
> ...
> {code}
> However it is never really used in {{CoarseGrainedSchedulerBackend}}. Its
> only usage is in Yarn-specific code. It should be moved to Yarn then because
> {{executorId}} is a {{String}} and there are really no guarantees that it is
> always an integer. It was introduced in SPARK-12864
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
