[
https://issues.apache.org/jira/browse/SPARK-27731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David C Navas updated SPARK-27731:
----------------------------------
Description:
Previous checkins cleaned up some of the odd exception propagation choices
(Throwables.propagate is deprecated), there's a little more work on that here.
Additionally, the InMemory's InstanceList wasn't previously generically typed,
which made some of the code excessively cautious. I added the generic typing
and removed the sprinkling of Precondition checks which seems to have been
designed to work around not having proper compile-time type checking. Also, it
turned out to be unnecessary to track the class in the KVStoreView, which
allows for the easy creation of an EMPTY_VIEW singleton.
Note that we also see an opportunity to simplify the KVStore implementation
tests as the verification of the KVStore APIs should be independent of the
implementation and the tests should probably be written once and then run
against both implementations. However, we decided not to attempt that at this
time.
was:Previous checkins cleaned up some of the odd exception propagation
choices (Throwables.propagate is deprecated), there's a little more work on
that here. Additionally, the InMemory's InstanceList wasn't previously
generically typed, which made some of the code excessively cautious. I added
the generic typing and removed the sprinkling of Precondition checks which
seems to have been designed to work around not having proper compile-time type
checking. Also, it turned out to be unnecessary to track the class in the
KVStoreView, which allows for the easy creation of an EMPTY_VIEW singleton.
> Cleanup some non-compile time type checking and exception handling
> ------------------------------------------------------------------
>
> Key: SPARK-27731
> URL: https://issues.apache.org/jira/browse/SPARK-27731
> Project: Spark
> Issue Type: Sub-task
> Components: Spark Core
> Affects Versions: 2.3.3
> Reporter: David C Navas
> Priority: Major
>
> Previous checkins cleaned up some of the odd exception propagation choices
> (Throwables.propagate is deprecated), there's a little more work on that
> here. Additionally, the InMemory's InstanceList wasn't previously
> generically typed, which made some of the code excessively cautious. I added
> the generic typing and removed the sprinkling of Precondition checks which
> seems to have been designed to work around not having proper compile-time
> type checking. Also, it turned out to be unnecessary to track the class in
> the KVStoreView, which allows for the easy creation of an EMPTY_VIEW
> singleton.
> Note that we also see an opportunity to simplify the KVStore implementation
> tests as the verification of the KVStore APIs should be independent of the
> implementation and the tests should probably be written once and then run
> against both implementations. However, we decided not to attempt that at
> this time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
