[
https://issues.apache.org/jira/browse/SPARK-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hyukjin Kwon resolved SPARK-12308.
----------------------------------
Resolution: Incomplete
> Better onDisconnected logic for Master
> --------------------------------------
>
> Key: SPARK-12308
> URL: https://issues.apache.org/jira/browse/SPARK-12308
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Reporter: Shixiong Zhu
> Priority: Major
> Labels: bulk-closed
>
> Pasting [~vanzin]'s comment from
> GitHub(https://github.com/apache/spark/pull/10261#issuecomment-164107825):
> bq. That's because we took opposite approaches. Your PR's approach is "if
> this connection says the sender address is a listening socket, then also
> consider that address when sending events about the remote process".
> bq. My PR takes the opposite approach: the address of the remote process is
> always the address of the socket used to connect, regardless of whether its
> also listening in another socket.
> bq. I think my approach is in the end more correct, but requires more code to
> fix existing code. In my view, RpcCallContext.senderAddress should be the
> address of the socket that sent the message, not the address the remote
> process is listening on.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
