Yesheng Ma created SPARK-28096:
----------------------------------

             Summary: Performance pitfall in Spark SQL LogicalPlans
                 Key: SPARK-28096
                 URL: https://issues.apache.org/jira/browse/SPARK-28096
             Project: Spark
          Issue Type: Bug
          Components: SQL
    Affects Versions: 3.0.0
            Reporter: Yesheng Ma


The original {{references}} and {{validConstraints}} implementations in a few 
QueryPlan and Expression classes are methods, which means unnecessary 
re-computation can happen at times. This PR resolves this problem by making 
these method lazy vals.

We benchmarked this optimization on TPC-DS queries whose planning time is 
longer than 1s. In the benchmark, we warmed up the queries 5 iterations and 
then took the average of 10 runs. Results showed that this micro-optimization 
can improve the end-to-end planning time by 25%.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to