Marco Gaido created SPARK-28201:
-----------------------------------

             Summary: Revisit MakeDecimal behavior on overflow
                 Key: SPARK-28201
                 URL: https://issues.apache.org/jira/browse/SPARK-28201
             Project: Spark
          Issue Type: Bug
          Components: SQL
    Affects Versions: 3.0.0
            Reporter: Marco Gaido


As pointed out in 
https://github.com/apache/spark/pull/20350#issuecomment-505997469, in special 
cases of decimal aggregation we are using the `MakeDecimal` operator.

This operator has a not well defined behavior in case of overflow, namely what 
it does currently is:

 - if codegen is enabled it returns null;
 -  in interpreted mode it throws an `IllegalArgumentException`.

So we should make his behavior uniform with other similar cases and in 
particular we should honor the value of the conf introduced in SPARK-23179 and 
behave accordingly, ie.:

 - returning null if the flag is true;
 - throw an `ArithmeticException` if the flag is false.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to