[
https://issues.apache.org/jira/browse/SPARK-28836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ali Afroozeh updated SPARK-28836:
---------------------------------
Summary: Remove the canonicalize(attributes) method from PlanExpression
(was: Remove the canonicalize() method )
> Remove the canonicalize(attributes) method from PlanExpression
> --------------------------------------------------------------
>
> Key: SPARK-28836
> URL: https://issues.apache.org/jira/browse/SPARK-28836
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 3.0.0
> Reporter: Ali Afroozeh
> Priority: Minor
>
> The canonicalize(attrs: AttributeSeq) method in PlanExpression is somewhat
> confusing.
> First, it is not clear why `PlanExpression` should have this method, and why
> the canonicalization is not handled
> by the canonicalized method of its parent, the Expression class. Second, the
> QueryPlan.normalizeExpressionId
> is the only place where PlanExpression.canonicalized is being called.
> This PR removes the canonicalize method from the PlanExpression class and
> delegates the normalization of expression ids to
> the QueryPlan.normalizedExpressionId method. Also, the name
> normalizedExpressions is more suitable for this method,
> therefore, the method has also been renamed.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
