Josh Rosen created SPARK-31003:
----------------------------------

             Summary: Fix incorrect use of assume() in tests
                 Key: SPARK-31003
                 URL: https://issues.apache.org/jira/browse/SPARK-31003
             Project: Spark
          Issue Type: Improvement
          Components: Tests
    Affects Versions: 3.0.0
            Reporter: Josh Rosen
            Assignee: Josh Rosen


[~ahirreddy] and I found some cases where {{assume}} and {{assert}} were mixed 
up in test suites.

If an {{assume}} call fails then it will cause the test to be marked as skipped 
instead of failed: this is often used to skip tests if certain prerequisites 
are missing (e.g. to disable certain tests on Windows). If {{assume}} is 
mistakenly used in place of {{assert}} then this can cause logically-failing 
tests to be skipped, masking bugs.

This patch fixes several such cases, replacing certain {{assume}} calls with 
{{assert}}. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to