[ 
https://issues.apache.org/jira/browse/SPARK-30896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056692#comment-17056692
 ] 

Takeshi Yamamuro commented on SPARK-30896:
------------------------------------------

Yea, +1 on the Wenchen suggestion; I also think we don't need to fix it now if 
the behaviour doesn't change.

>> More importantly, what should be the official way when we add new configs 
>> that can affect expression behavior? Shall we just store the config value in 
>> a `val` or put it in the expression constructor?

I personally think, to avoid the corner case as you suggested above, having 
config values in constructors looks clearer than the other.

> The behavior of JsonToStructs should not depend on SQLConf.get
> --------------------------------------------------------------
>
>                 Key: SPARK-30896
>                 URL: https://issues.apache.org/jira/browse/SPARK-30896
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Wenchen Fan
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to