[
https://issues.apache.org/jira/browse/SPARK-31579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107609#comment-17107609
]
Sudharshann D. commented on SPARK-31579:
----------------------------------------
Just a small update. I have the design for the issue. Its something similar to
this:
# Write a duplicate of localRebaseGregorianToJulianDays() with / instead of
floor div and with extra parameters days: Int,
tz: TimeZone, hr: Int.
# Write test cases that iterate over all days, all timezones, and each hour
and compare the result of floorDiv and /.
# Send the PR with this modification. If you think its fine, I'll clear all
the edits and replace floorDiv by /
I have the code but there's something wrong with my dev environment...Figuring
it out...
> Replace floorDiv by / in localRebaseGregorianToJulianDays()
> -----------------------------------------------------------
>
> Key: SPARK-31579
> URL: https://issues.apache.org/jira/browse/SPARK-31579
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 3.1.0
> Reporter: Maxim Gekk
> Priority: Minor
> Labels: starter
>
> Most likely utcCal.getTimeInMillis % MILLIS_PER_DAY == 0 but need to check
> that for all available time zones in the range of [0001, 2100] years with the
> step of 1 hour or maybe smaller. If this hypothesis is confirmed, floorDiv
> can be replaced by /, and this should improve performance of
> RebaseDateTime.localRebaseGregorianToJulianDays.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
